Skip to content

Conversation

RReichert
Copy link
Contributor

Do Not Merge - this is an project PR

woodfell added 3 commits June 8, 2021 12:32
* Implement automated tests for new API

* Fixup after rebase

* Disable -Warray-bounds in legacy C++ unit tests
@woodfell woodfell changed the title Portability Project [WIP] [ESD-2043] Portability project Jun 8, 2021
woodfell and others added 13 commits June 8, 2021 16:08
* Start refactoring header template

* Lots more comments, not sure it's actually an improvement though

* Update dates and header guards

* Try a different header file structure (#1001)
* Add doc to the sbp_msg.h file

* Adds the generated sbp_msg.h file
* Update message traits template

* include guard
* Create a write callback typedef

* Update c/include/libsbp/common.h

Co-authored-by: Sam Lewis <[email protected]>

Co-authored-by: Sam Lewis <[email protected]>
* Move files, replace 'new' -> 'v4'

* Renaming

* Rename string functions

* generated str funcs parameter

* include guards

* Sort sbp_msg and mesage traits
* Doxygen errors

* fixes

* fixes
*.*~
limbo/
.idea/
*.bak
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

* Move examples to legacy folder

* Add base v4 examples (direct copy from legacy examples)

* Update example to v4

* Fix function name in message handler

* Update cpp example for v4 API

* Update example READMEs

Co-authored-by: Jason Mobarak <[email protected]>

Co-authored-by: Jason Mobarak <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
4.9% 4.9% Duplication

* cmake - SV4-144 update googleflags (#1010)

Triggered-By:	cmake	381389639e0b4b9956b65c53c6794c149cd99990
Upstream-PR:	http://github.com/swift-nav/cmake/pull/83

* rust: impl TryFrom<SBP> for all messages (#1009)

* Release v3.4.8

* prep for next release

* python: update deploy script #no_auto_pr

* docs: update docker tag #no_auto_pr

* docs: update python dist instructions #no_auto_pr

* test_structs.py: Fix missing attribute

* generator/sbpg/targets/test_*.py: Fix override import

render_source was being imported and then overridden
by a local function, causing an error found by pylint -E

* generator/requirements.txt: Require Jinja2>3

Recent additions to the generator are using functionality
only available in Jinja2 v3, causing pylint errors if
Jinja2 v2 was installed.

* yaml2.py: Fix undefined variable

* forwarder.py: Fix missing attribute

These were masked by the bare-except they are within.

* forwarder.py: __exit__ accepts three params

* sbp.client.loggers: Workaround pylint analysis

pylint latest(2.8.3) requires these changes to side step its
analysis.

* python: Prevent AttributeError with pyserial v3.5

writeTimeoutError was renamed to SerialTimeoutException.
Allow both, so users can choose stable 3.4 or newer 3.5

* python/tests: Disable pylint error

* generator test targets: Improve imports

* generator: Remove unused imports

* Use autoflake to trim imports

* python/bench/crc.py: Clarify unused variable

* javascript: Remove generated duplicated GPSTime

This is a byproduct of d5f3ad0

* Sphinx conf.py: Update year from 2015 to 2021

* Sphinx conf.py: Deduplicate strings

* generator: Fix sonarcloud issues

* python/bench/memory.py: Clarify unused variable

* yaml2.py: Raise more specific exception

Raising Exception makes catching the exception difficult.

* templating.py: Re-order do_wordwrap params

sonarcloud is marking these keyword params as an error.
Possibly it is wanting the order of the args to match
the declared params for the function.

* generator: Remove unused function argument

The do_wordwrap parameter "blank" was modified to be
automatically determined.

* generator: Use yaml.safe_load

* Javascript lint fixes

* test_dispatch.js: Fix variable shadowing

* test_dispatch.js: Remove code duplication

Uses event listeners to process the assertions
after the callbacks have completed.

* test_dispatch_decoder.js: Remove code duplication

* test_dispatch_decoder.js: Use while loops

For loops with different variables in condition vs
incrementors causes a sonarcloud critical code smell.

* javascript: Replace var with let

Avoids warnings of reusing variable names.

* Update sbp.bundle.js

* build.gradle: Add sonarcloud

* Java CI: Run sonarqube

* Java CI: Add GITHUB_TOKEN to sonarqube task

* cmake - memcheck_xml2junit_converter.py: Remove redundancy (#1033)

SonarCloud complains about the repeated string.

Triggered-By:	cmake	373d4fcafbbc0c208dc9ecb278d36ed8c9448eda

* sbp_java.java.j2: Remove duplicate import

* SBPMessage.java: Use StandardCharsets.UTF_8

As a consequence, getString can not throw SBPBinaryException.

* Add SonarCloud Github Action

* build.gradle: Set project name

* Reformat java using AOSP style

Also removes duplicate imports, updates copyright year,
adds missing `package` declarations and generated note.

Also adds inline comment for parse/build methods
without any additional fields.

* build.gradle: Add coverage reporting

* build.gradle: Fix gradle 4 compatibility

xml.required is not supported on gradle 4.

* fix merge bugs

* Fix github workflow?

* kick

Co-authored-by: swiftnav-svc-jenkins <[email protected]>
Co-authored-by: Steven Meyer <[email protected]>
Co-authored-by: Jason Mobarak <[email protected]>
Co-authored-by: John Vandenberg <[email protected]>
Matt Woodward and others added 18 commits July 16, 2021 12:07
* Add "to_sbp_msg" functions in MessageTraits

This is useful when using C++ templated functions that use the SBP
message types. It can be useful to map back from the message types to
the sbp_msg_t union, to allow the messages to be processed.

* Add simple example of MessageTraits::to_sbp_msg
* Update the set string functions for unterminated & null-terminated

Adds a truncate option that, if set, truncates the input string so that
it can fit in the string object. This has also meant that the internal
functions need to be given the size of the string by the user, so that
this can be used will non null terminated strings.

Co-authored-by: Matt Woodward <[email protected]>
…ss (#1054)

* Update function name in sbp.c to match what's declared in api.h

(sbp_message_process)

* Add process_message function to state class

This allows unpacked structs to trigger callback functions registered
against the C++ state class.
* [ESD-215] Add converter for gnss message variants

* change code to be more readable

* code change from code review suggestions
@woodfell woodfell changed the title [WIP] [ESD-2043] Portability project [ESD-2043] Portability project Sep 2, 2021
@woodfell woodfell merged commit 989d77d into master Sep 2, 2021
@woodfell woodfell deleted the ESD-2043-portability-project branch September 2, 2021 05:19
@silverjam silverjam restored the ESD-2043-portability-project branch May 4, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants